Add Monitor Refresh Rate Changer plugin configuration#683
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce2f9c8fc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "ID": "f38c9470-7d31-401e-88ca-06c964bb3fc3", | |||
| "ActionKeyword": "hz", | |||
There was a problem hiding this comment.
This repository only allows the fields listed in necessary_fields and optional_fields; adding ActionKeyword makes python -m pytest ci/src/validator.py -q fail in test_optional_fields with unknown fields: ['ActionKeyword'], so this manifest cannot pass CI until this field is removed.
Useful? React with 👍 / 👎.
| { | ||
| "ID": "f38c9470-7d31-401e-88ca-06c964bb3fc3", | ||
| "ActionKeyword": "hz", | ||
| "Name": "Monitor Refresh Rate Changer", |
There was a problem hiding this comment.
With this Name, the validator expects the file to be named exactly Monitor Refresh Rate Changer-f38c9470-7d31-401e-88ca-06c964bb3fc3.json; the added file omits the spaces in the plugin name, so test_file_name_construct fails and blocks the submission. Rename the file or change the manifest name so they match.
Useful? React with 👍 / 👎.
| "Language": "python", | ||
| "Website": "https://github.com/psycodess/hz-plugin", | ||
| "IcoPath": "https://cdn.jsdelivr.net/gh/psycodess/hz-plugin@main/Images/app.png", | ||
| "UrlDownload": "https://github.com/psycodess/hz-plugin/raw/main/hz-plugin.zip", |
There was a problem hiding this comment.
The manifest validator requires UrlDownload to match the GitHub releases/download/.../*.zip pattern, but this points at a raw file on main; test_valid_download_url fails for this plugin. Publish the zip as a release asset and use that immutable https://github.com/<owner>/<repo>/releases/download/<tag>/<file>.zip URL instead.
Useful? React with 👍 / 👎.
jjw24
left a comment
jjw24
left a comment
There was a problem hiding this comment.
Hi @psycodess, please action the review comments from Copilot review.
2 participants
Hey there I have created a plug in for changing the refresh rate of any monitor connected on Windows It can work on multiple monitors too